Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade urllib3 version #419

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Upgrade urllib3 version #419

merged 1 commit into from
Mar 1, 2024

Conversation

dibryant
Copy link
Contributor

Fixes for https://issues.redhat.com/browse/RHOAIENG-1253

Description

upgraded urllib3 to 1.26.18 as suggested by Snyk

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 February 20, 2024 15:44
@dibryant dibryant force-pushed the CVE branch 2 times, most recently from 586f0bb to 5f947f6 Compare February 22, 2024 20:28
@dibryant
Copy link
Contributor Author

My system will not allow me to update the pipfile.lock for pytorch. Can one of you update and push it out for me? @harshad16 @atheo89 @rkpattnaik780

@dibryant
Copy link
Contributor Author

/retest-required

@atheo89
Copy link
Member

atheo89 commented Feb 26, 2024 •
edited
Loading

Hi @dibryant the pipfile.lock files seems that have some discrepancy among the versions according to the ci tests. In order to update them outside from your system you can do the following:

  1. Update the L26 with the name of your branch CVE
  2. Create a token secret with the following name: GH_ACCESS_TOKEN. How to: link
  3. Trigger the Action, to generate the pipfiles for you
  4. Once it is done commit the ONLY the piplock files. Attention don't commit the changes from the workflow.

@atheo89
Copy link
Member

atheo89 commented Feb 29, 2024

Hey @dibryant this PR needs a rebase, do you need a help on this?

@dibryant
Copy link
Contributor Author

Hey @dibryant this PR needs a rebase, do you need a help on this?

Yes If you have time today.

@dibryant
Copy link
Contributor Author

/retest-required

harshad16
harshad16 requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
though we should reomve this commit:
dc2309b

@harshad16
Copy link
Member

/lgtm
/approve

👍

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 61e23b7 into opendatahub-io:main Mar 1, 2024
12 checks passed
@harshad16
Copy link
Member

/cherrypick 2023b

@openshift-cherrypick-robot
Copy link

@harshad16: new pull request created: #441

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 1, 2024
Merged
@harshad16 harshad16 mentioned this pull request Mar 1, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@harshad16 harshad16 harshad16 requested changes

@atheo89 atheo89 Awaiting requested review from atheo89

Assignees

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dibryant @atheo89 @harshad16 @openshift-cherrypick-robot @jstourac @openshift-merge-robot